Skip to content

Add deployment health check implementation#2359

Merged
tejal29 merged 25 commits intoGoogleContainerTools:masterfrom
tejal29:add_healthcheck
Jul 11, 2019
Merged

Add deployment health check implementation#2359
tejal29 merged 25 commits intoGoogleContainerTools:masterfrom
tejal29:add_healthcheck

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Jun 27, 2019

This PR depends on #2338 to go in.

This in addition to add status-check flag covered in #2338, does the following

  • implements the status check for deployment by

    • get a list of skaffold deployed deployments using label -l app.kubernetes.io/managed-by=skaffold-<version>
    • for every deployment, get the spec.progressDeadline if set or set it to 10 minutes.
    • run kubectl rollout status after every 600 ms which is the default polling period.
    • finally either pass or fail depending on if the deployment was stabalized
  • Add unit tests

  • Add integration tests.

TODO:

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2019

Codecov Report

Merging #2359 into master will decrease coverage by <.01%.
The diff coverage is 68.35%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/kubectl/cli.go 96% <100%> (+0.44%) ⬆️
pkg/skaffold/deploy/status_check.go 66.17% <66.17%> (ø)
pkg/skaffold/runner/runner.go 70.67% <66.66%> (-0.65%) ⬇️

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall!

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a nit and small questions

@tejal29 tejal29 merged commit 9981c37 into GoogleContainerTools:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants