Add deployment health check implementation#2359
Merged
tejal29 merged 25 commits intoGoogleContainerTools:masterfrom Jul 11, 2019
Merged
Add deployment health check implementation#2359tejal29 merged 25 commits intoGoogleContainerTools:masterfrom
tejal29 merged 25 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
priyawadhwa
approved these changes
Jul 10, 2019
Contributor
priyawadhwa
left a comment
There was a problem hiding this comment.
LGTM! Just a nit and small questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2338 to go in.
This in addition to add
status-checkflag covered in #2338, does the followingimplements the status check for deployment by
-l app.kubernetes.io/managed-by=skaffold-<version>kubectl rollout statusafter every 600 ms which is the default polling period.Add unit tests
Add integration tests.
TODO: