Skip to content

Add a test to Kaniko builder#2371

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:add-test-kaniko
Jul 1, 2019
Merged

Add a test to Kaniko builder#2371
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:add-test-kaniko

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jun 28, 2019

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 28, 2019

Codecov Report

Merging #2371 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 76.34% <0%> (-2.16%) ⬇️
pkg/skaffold/docker/client.go 69.6% <0%> (-1.97%) ⬇️
pkg/skaffold/build/cluster/sources/sources.go 90.9% <0%> (+14.77%) ⬆️

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgageot dgageot merged commit e7d8cdc into GoogleContainerTools:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants