Jib Builder: add more tests

[dgageot]

Signed-off-by: David Gageot david@gageot.net

[codecov]

Codecov Report

Merging #2390 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
pkg/skaffold/build/local/local.go	36.76% <ø> (ø)	⬆️
pkg/skaffold/build/local/jib_gradle.go	100% <100%> (+30.43%)	⬆️
pkg/skaffold/build/local/jib_maven.go	100% <100%> (+22.22%)	⬆️

[loosebazooka]

I don't really understand this specific part? Does this just become a variable in the scope of the local pkg? Was there some problem with using the direct reference (docker.RemoteDigest) in the jib files? Mostly because it seems harder to find the reference now, when looking through code.

[dgageot]

This is the simplest way to mock the call to docker.RemoteDigest. We use that pattern in. a lot of places.

[dgageot]

@loosebazooka Looks like the changes to the owners file are still not enough

[TadCordle]

Might be because you made a change to local.go?

[loosebazooka]

@dgageot as a followup perhaps change all of the docker.RemoteDigest -> getRemoteDigest ?

build/local/bazel.go:90: return docker.RemoteDigest(tag, insecureRegistries)
build/local/custom.go:38: return docker.RemoteDigest(tag, b.insecureRegistries)
build/cache/save.go:110: return docker.RemoteDigest(img, c.insecureRegistries)
build/cache/save.go:114: return docker.RemoteDigest(img, c.insecureRegistries)
build/cache/cache.go:58: remoteDigest    = docker.RemoteDigest
build/cluster/kaniko.go:91: return docker.RemoteDigest(tag, b.insecureRegistries)
build/cluster/cluster.go:71: return docker.RemoteDigest(tag, b.insecureRegistries)

[dgageot]

Well, let’s do it only when a test requires it.