Skip to content

Custom Builder: Fix bug when no deps specified#2391

Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2166
Jul 2, 2019
Merged

Custom Builder: Fix bug when no deps specified#2391
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2166

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jul 2, 2019

Fix #2166

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2019

Codecov Report

Merging #2391 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/validation/validation.go 100% <100%> (+2.43%) ⬆️
pkg/skaffold/jib/jib.go 77.41% <0%> (-1.08%) ⬇️

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 7fe4c6f into GoogleContainerTools:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CustomArtifact builder panics if no dependencies specified

3 participants