Skip to content

Move docker code where it belongs#2393

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:docker-push
Jul 3, 2019
Merged

Move docker code where it belongs#2393
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:docker-push

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jul 2, 2019

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2019

Codecov Report

Merging #2393 into master will not change coverage.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 35.71% <0%> (+6.72%) ⬆️
pkg/skaffold/docker/remote.go 35.41% <0%> (-13.16%) ⬇️

@priyawadhwa
Copy link
Copy Markdown
Contributor

I'm guessing flaky integration test?

--- FAIL: TestDebug (600.04s)
    --- FAIL: TestDebug/kubectl (300.03s)
        util.go:107: Timed out waiting for pods [nodejs npm python3] ready in namespace skaffoldjssjz
    --- FAIL: TestDebug/kustomize (300.01s)
        util.go:107: Timed out waiting for pods [nodejs npm python3] ready in namespace skaffoldk55hl

@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Jul 2, 2019

Yes, this test is super flaky and I forgot to create an issue for it

@dgageot dgageot force-pushed the docker-push branch 2 times, most recently from 525b9ff to c61eed3 Compare July 3, 2019 19:40
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat merged commit 251bdba into GoogleContainerTools:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants