Feat(sync): skip sync on non-running pods#2403
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jul 5, 2019
Merged
Conversation
seblegall
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
seblegall
force-pushed
the
feat/skip-sync-on-non-running-containers
branch
2 times, most recently
from
4dafebc to
26a4407
Compare
Contributor
|
@seblegall When #2413 is merged, you can rebase and the test suite should be all green |
Contributor
Author
|
ok, great. |
Contributor
|
@seblegall you should be able to rebase on top of the now better test suite! |
Fix issue GoogleContainerTools#2360 The goal of this PR is to avoid trying to sync files in a pod which is not in a running state. It should avoid errors when working on a single artifact which is deployed in different pods. For example : one running a webserver and another running a work or a job. This is typically something that could happend when a microservice is able to run both web server and a job which make some sort of batch treatments on the database.
seblegall
force-pushed
the
feat/skip-sync-on-non-running-containers
branch
from
26a4407 to
3b2d8e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #2360
The goal of this PR is to avoid trying to sync files in a pod which is
not in a running state. It should avoid errors when working on a single
artifact which is deployed in different pods. For example : one running
a webserver and another running a work or a job. This is typically
something that could happend when a microservice is able to run both web
server and a job which make some sort of batch treatments on the database.