Skip to content

Support alternative Kustomization config filenames (#2422)#2439

Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
jmcclell:kustomize-configs
Jul 11, 2019
Merged

Support alternative Kustomization config filenames (#2422)#2439
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
jmcclell:kustomize-configs

Conversation

@jmcclell
Copy link
Copy Markdown
Contributor

Closes #2422

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2019

Codecov Report

Merging #2439 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kustomize.go 78.07% <100%> (+3.54%) ⬆️

@jmcclell
Copy link
Copy Markdown
Contributor Author

Not sure why tests failed for linux. Looks unrelated to the patch, however?

@priyawadhwa
Copy link
Copy Markdown
Contributor

@jamielennox we just merged a change to our proto files, could you try rebasing on master?

@jmcclell jmcclell force-pushed the kustomize-configs branch from 8d7b267 to 675b553 Compare July 11, 2019 02:37
…ols#2422)

Kustomize supports 3 config filenames:

- kustomization.yaml
- kustomization.yml
- Kustomization
@jmcclell jmcclell force-pushed the kustomize-configs branch from 675b553 to 511c77f Compare July 11, 2019 03:01
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jul 11, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 11, 2019
@priyawadhwa priyawadhwa merged commit 6b8cd3f into GoogleContainerTools:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for alternative Kustomization config names

5 participants