Merged
Conversation
6b26b8b to
ff96857
Compare
This PR simplifies caching to the following rules, described in my second design doc for artifact caching: If remote cluster or push:true : 1. Check if image exists remotely. 2. If not, check if same digest exists locally. If it does, retag and repush. 3. If not, rebuild and repush. If local cluster, and push:false: 1. Check if image exists locally 2. If not, check if same digest exists locally. If it does, retag. 3. If not, rebuild
ff96857 to
122d61f
Compare
Codecov Report
|
dgageot
approved these changes
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies caching to the following rules, described in my
second design doc for artifact caching:
If remote cluster or push:true :
If local cluster, and push:false: