Skip to content

Default to notify trigger#2482

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-1566
Jul 16, 2019
Merged

Default to notify trigger#2482
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-1566

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jul 16, 2019

Fixes #1566

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#1566

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2019

Codecov Report

Merging #2482 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/dev.go 84.61% <100%> (ø) ⬆️

Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@balopat balopat merged commit b847545 into GoogleContainerTools:master Jul 16, 2019
@yolkov
Copy link
Copy Markdown

yolkov commented Jul 24, 2019

'notify' not working for Docker Desktop for Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make notify based trigger the default

4 participants