Improve Jib support on gcb#2548
Merged
dgageot merged 4 commits intoGoogleContainerTools:masterfrom Jul 31, 2019
Merged
Conversation
dgageot
requested review from
TadCordle,
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala,
priyawadhwa and
tejal29
as code owners
chanseokoh
reviewed
Jul 25, 2019
Codecov Report
|
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
Jib changes LGTM. The build steps → description is a bit over my head at the moment.
dgageot
force-pushed
the
jib-on-gcb
branch
4 times, most recently
from
572065d to
61f6653
Compare
Fix GoogleContainerTools#2546 Also took the opportunity to improve tests a bit. Should give builds that are slightly faster since they will by default use a builder image that's already cached on GCB. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
briandealwis
approved these changes
Jul 31, 2019
| } | ||
|
|
||
| builder := newBuilder(latest.GoogleCloudBuild{ | ||
| MavenImage: "maven:3.6.0", |
Member
There was a problem hiding this comment.
Do you think this should be 3.6.1?
Contributor
Author
There was a problem hiding this comment.
This is just a test. Could be foobar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2546