Add option in global config to define default kube-contexts#2558
Closed
corneliusweig wants to merge 8 commits intoGoogleContainerTools:masterfrom
Closed
Add option in global config to define default kube-contexts#2558corneliusweig wants to merge 8 commits intoGoogleContainerTools:masterfrom
corneliusweig wants to merge 8 commits intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
This command associates a skaffold.yaml with the given kube-context. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
This command removes an association of a skaffold.yaml with a kube-context. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
f083476 to
b22e3c5
Compare
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Codecov Report
|
Contributor
Author
|
As discussed in #2510 (comment), the global config option for the kube-context might be an overengineering of the kube-context configurability. Therefore, I'm going to close this for now to put these changes on hold. If somebody sees an urgent need to get this functionality in, I'm happy to revive this PR. But let's first see how users get along with just the CLI option and the At the very least #2325 is affected. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See design proposal #2384
Depends on
#2447,#2509, and#2555(all prerequisites have been merged)