skaffold generate-pipeline command#2567
Merged
tejal29 merged 22 commits intoGoogleContainerTools:masterfrom Aug 7, 2019
Merged
skaffold generate-pipeline command#2567tejal29 merged 22 commits intoGoogleContainerTools:masterfrom
tejal29 merged 22 commits intoGoogleContainerTools:masterfrom
Conversation
Need to figure out how to flatten CRD metadata when marshaling and omitempty for yaml on the tektoncd/pipeline api.
for now only adds name, needs profile content
…fold into gen-pipeline
priyawadhwa
reviewed
Jul 31, 2019
Contributor
priyawadhwa
left a comment
There was a problem hiding this comment.
This is looking really good! Left some organizational comments and nits :)
tejal29
previously requested changes
Aug 1, 2019
integration/testdata/generate_pipeline/no_profiles/expectedSkaffold.yaml
Show resolved
Hide resolved
Contributor
|
@marlon-gamez Can you also run |
tejal29
reviewed
Aug 1, 2019
Contributor
|
one small nit remaing |
Codecov Report
|
tejal29
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a new skaffold command that allows users to generate a Tekton pipeline (https://github.com/tektoncd/pipeline) by reading their skaffold config file and generating corresponding build and deploy tasks. The command also adds a profile to the users skaffold.yaml, which is used by the pipeline when running the tasks on cluster.
In order to use the generated pipeline, the user must run the command, then commit and push the changes to their skaffold config file.
Currently, building on this branch won't work because the tekton api has outdated dependencies, which has been addressed in this pr (tektoncd/pipeline#1117). Building should be fixed once the next release of Tekton pipelines is out.
TODO: