Skip to content

skaffold generate-pipeline command#2567

Merged
tejal29 merged 22 commits intoGoogleContainerTools:masterfrom
marlon-gamez:gen-pipeline
Aug 7, 2019
Merged

skaffold generate-pipeline command#2567
tejal29 merged 22 commits intoGoogleContainerTools:masterfrom
marlon-gamez:gen-pipeline

Conversation

@marlon-gamez
Copy link
Copy Markdown
Contributor

@marlon-gamez marlon-gamez commented Jul 29, 2019

This pr adds a new skaffold command that allows users to generate a Tekton pipeline (https://github.com/tektoncd/pipeline) by reading their skaffold config file and generating corresponding build and deploy tasks. The command also adds a profile to the users skaffold.yaml, which is used by the pipeline when running the tasks on cluster.

In order to use the generated pipeline, the user must run the command, then commit and push the changes to their skaffold config file.

Currently, building on this branch won't work because the tekton api has outdated dependencies, which has been addressed in this pr (tektoncd/pipeline#1117). Building should be fixed once the next release of Tekton pipelines is out.

TODO:

  • add integration tests
  • update Tekton dependency when new release occurs

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! Left some organizational comments and nits :)

tejal29
tejal29 previously requested changes Aug 1, 2019
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Aug 1, 2019

@marlon-gamez Can you also run go mod tidy to prune unused dependencies?
I dont' think we are using all of Tekton. Let me know if you don't see the number of files reduced.

@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Aug 2, 2019

one small nit remaing

INFO [loader] SSA repr building timing: packages building 287.10442ms, total 6.187174947s 
204integration/generate_pipeline_test.go:38:3: U1000: field `args` is unused (unused)
205		args        []string

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2019

Codecov Report

Merging #2567 into master will decrease coverage by 0.46%.
The diff coverage is 52.4%.

Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 0% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/cmd.go 68% <100%> (+0.25%) ⬆️
pkg/skaffold/pipeline/task.go 100% <100%> (ø)
pkg/skaffold/pipeline/pipeline.go 100% <100%> (ø)
pkg/skaffold/runner/generate_pipeline.go 43.97% <43.97%> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 45.45% <45.45%> (ø)
pkg/skaffold/pipeline/pipeline_resource.go 68.42% <68.42%> (ø)
... and 2 more

@marlon-gamez marlon-gamez marked this pull request as ready for review August 6, 2019 21:48
@tejal29 tejal29 merged commit d7fa4a4 into GoogleContainerTools:master Aug 7, 2019
@marlon-gamez marlon-gamez deleted the gen-pipeline branch August 7, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants