[linters] Use vendored dependencies. Don’t download them.#2579
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jul 31, 2019
Merged
[linters] Use vendored dependencies. Don’t download them.#2579dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
This can’t be set on the command line. We have to use a config file. Also, removed the `--skip-dirs vendor` because it’s done by default by golangci-lint. Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
Contributor
Author
|
FYI, I'm going to self merge this one to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behaviour can’t be set on the command line. We have to use a config file.
Also, removed the
--skip-dirs vendorbecause it’s done by default by golangci-lint.Signed-off-by: David Gageot david@gageot.net