Skip to content

Make sure we mute/unmute logs at the correct times#2592

Merged
balopat merged 1 commit intoGoogleContainerTools:release/v0.35.0from
nkubala:unmute-logs
Aug 2, 2019
Merged

Make sure we mute/unmute logs at the correct times#2592
balopat merged 1 commit intoGoogleContainerTools:release/v0.35.0from
nkubala:unmute-logs

Conversation

@nkubala
Copy link
Copy Markdown
Contributor

@nkubala nkubala commented Jul 31, 2019

This change makes sure that in the dev loop, we:

  • only mute logs whenever we're going to perform an action, and
  • only unmute logs when we've successfully performed an action

Fixes #2530

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2592 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 38.93% <ø> (ø) ⬆️
pkg/skaffold/runner/dev.go 67.61% <100%> (+1.61%) ⬆️
pkg/skaffold/jib/jib.go 77.41% <0%> (-1.08%) ⬇️

@balopat balopat changed the base branch from master to release/v0.35.0 August 2, 2019 20:26
@balopat balopat merged commit 1903df3 into GoogleContainerTools:release/v0.35.0 Aug 2, 2019
@nkubala nkubala deleted the unmute-logs branch October 17, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants