Skip to content

docs: clarify that tagged images in manifests are not replaced#2598

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:w/doc-update
Aug 22, 2019
Merged

docs: clarify that tagged images in manifests are not replaced#2598
balopat merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:w/doc-update

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

Related #2547

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2019

Codecov Report

Merging #2598 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config/unset.go 15.38% <0%> (-67.95%) ⬇️
cmd/skaffold/app/cmd/config/list.go 0% <0%> (-65.22%) ⬇️
...ffold/kubernetes/portforward/resource_forwarder.go 56% <0%> (-32%) ⬇️
cmd/skaffold/app/cmd/config/set.go 71.01% <0%> (-13.2%) ⬇️
pkg/skaffold/deploy/util.go 68% <0%> (-10.95%) ⬇️
pkg/skaffold/runner/runcontext/context.go 62.5% <0%> (-9.6%) ⬇️
pkg/skaffold/initializer/init.go 53.6% <0%> (-7.69%) ⬇️
pkg/skaffold/trigger/triggers.go 30.95% <0%> (-2.75%) ⬇️
pkg/skaffold/deploy/helm.go 64.9% <0%> (-1.64%) ⬇️
pkg/skaffold/runner/deploy.go 70.58% <0%> (-1.64%) ⬇️
... and 42 more

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Aug 3, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 3, 2019
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit ea2564f into GoogleContainerTools:master Aug 22, 2019
@corneliusweig corneliusweig deleted the w/doc-update branch August 22, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants