Skip to content

Watch all artifact workspaces, including those outside of the working directory#2614

Merged
nkubala merged 3 commits intoGoogleContainerTools:masterfrom
priyawadhwa:filewatch-bug
Aug 8, 2019
Merged

Watch all artifact workspaces, including those outside of the working directory#2614
nkubala merged 3 commits intoGoogleContainerTools:masterfrom
priyawadhwa:filewatch-bug

Conversation

@priyawadhwa
Copy link
Copy Markdown
Contributor

This should fix #2613: Watcher doesn't detect changes when artifacts are outside the directory from where skaffold is run

dir

This should fix GoogleContainerTools#2613: Watcher doesn't detect changes when artifacts are outside the directory from where skaffold is run
Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you fix the lint issue?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2019

Codecov Report

Merging #2614 into master will decrease coverage by 0.49%.
The diff coverage is 72.72%.

Impacted Files Coverage Δ
pkg/skaffold/trigger/triggers.go 33.69% <72.72%> (+2.74%) ⬆️
pkg/skaffold/deploy/status_check.go 63.23% <0%> (-4.46%) ⬇️
pkg/skaffold/runner/new.go 70.07% <0%> (ø) ⬆️
pkg/skaffold/schema/defaults/defaults.go 90.41% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <0%> (ø) ⬆️
pkg/skaffold/schema/versions.go 74.35% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 0% <0%> (ø) ⬆️
pkg/skaffold/pipeline/pipeline_resource.go 68.42% <0%> (ø)
pkg/skaffold/pipeline/pipeline.go 100% <0%> (ø)
pkg/skaffold/generate_pipeline/profile.go 21.12% <0%> (ø)
... and 6 more

@priyawadhwa
Copy link
Copy Markdown
Contributor Author

thanks @nkubala , done

@nkubala nkubala merged commit 1603de1 into GoogleContainerTools:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watcher doesn't detect changes when artifacts are outside the directory from where skaffold is run

3 participants