Skip to content

Remove time sensitive tests#2655

Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:fix_int_flake
Aug 22, 2019
Merged

Remove time sensitive tests#2655
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:fix_int_flake

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Aug 15, 2019

fixes #2606
In #2591, i removed the test to check expected number of call and switched to testutil.NewFakeCmd.
However, some PRs would still see another test flake, where the below test would not return success within 80ms

-               }, {
-                       description: "rollout returns success before time out",
-                       command: testutil.NewFakeCmd(t).
-                               WithRunOut(rolloutCmd, "Waiting for rollout to finish: 0 of 1 updated replicas are available...").
-                               WithRunOut(rolloutCmd, "Waiting for rollout to finish: 0 of 1 updated replicas are available...").
-                               WithRunOut(rolloutCmd, "deployment.apps/dep successfully rolled out"),
-                       duration: 80

Removing this time dependent test case for now.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2019

Codecov Report

Merging #2655 into master will not change coverage.
The diff coverage is n/a.

@nkubala nkubala merged commit f552c67 into GoogleContainerTools:master Aug 22, 2019
@tejal29 tejal29 deleted the fix_int_flake branch September 18, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake:TestPollDeploymentRolloutStatus

4 participants