Design proposal for integrationtest command#2671
Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom Sep 6, 2019
daddz:dp-integrationtest
Merged
Design proposal for integrationtest command#2671tejal29 merged 2 commits intoGoogleContainerTools:masterfrom daddz:dp-integrationtest
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
daddz:dp-integrationtest
Conversation
Codecov Report
|
Contributor
|
hey @daddz, thanks for writing this up! we really appreciate your interest in this and the effort you went through to draft this up, but we've decided that at the moment this isn't a direction we want to go with skaffold - see my comment on your related issue for a bit more explanation. apologies for having to send this one back, but thanks for being so enthusiastic about building new features in skaffold! |
tejal29
approved these changes
Sep 6, 2019
Contributor
tejal29
left a comment
There was a problem hiding this comment.
Added reason for cancellation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #2594
Related issues: #2561, #992