Improve logging warning when enountering profile field of unhandled type#2691
Merged
tejal29 merged 4 commits intoGoogleContainerTools:masterfrom Aug 21, 2019
Merged
Conversation
tejal29
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging for the error fixed in #2662 is a bit puzzling:
It seems that the name for primitive fields is just the type. This PR changes the callers of
overlayProfileField()to pass in the YAML field name, and adds a new function in theyamltagspackage to extract theyamltag name from aStructField.You can see it in action by adding a new field of an unsupported basic type, like
float32: