Skip to content

Restore original images only if there are no remote manifests#2746

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2690
Aug 28, 2019
Merged

Restore original images only if there are no remote manifests#2746
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2690

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Aug 28, 2019

  • When there's no remote manifests, this PR restores the original cleanup code that used to be rock solid.
  • If there are remote manifests then it does things I don't really understand. We need to dig a little deeper.

Fixes #2690

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2019

Codecov Report

Merging #2746 into master will increase coverage by <.01%.
The diff coverage is 54.54%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl.go 65.81% <54.54%> (+0.29%) ⬆️

@balopat balopat merged commit 0c58c59 into GoogleContainerTools:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skaffold not cleaning up resources on termination

3 participants