Refactor deployment healthcheck#2750
Closed
tejal29 wants to merge 5 commits intoGoogleContainerTools:masterfrom
Closed
Refactor deployment healthcheck#2750tejal29 wants to merge 5 commits intoGoogleContainerTools:masterfrom
tejal29 wants to merge 5 commits intoGoogleContainerTools:masterfrom
Conversation
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
Codecov Report
|
dgageot
suggested changes
Aug 29, 2019
Contributor
dgageot
left a comment
dgageot
left a comment
There was a problem hiding this comment.
@tejal29 I've only reviewed the UX, not the code.
It looks like it's doing the job which is awesome!
It would be even better if the output could be streamlined and refined.
Here's what I see:
Deploy complete in 378.581679ms
Waiting for deployments to stabilize
deployment/leeroy-app is pending due to Waiting for deployment "leeroy-app" rollout to finish: 1 old replicas are pending termination...
deployment/leeroy-web is pending due to Waiting for deployment "leeroy-web" rollout to finish: 1 old replicas are pending termination...
deployment/leeroy-app is ready. [1/2 deployment(s) still pending]
deployment/leeroy-web is ready.
Here's what I'd love to see:
Deploy complete in 378.581679ms
Waiting for deployments to stabilize...
- Waiting for deployment "leeroy-app" rollout to finish: 1 old replicas are pending termination...
- Waiting for deployment "leeroy-web" rollout to finish: 1 old replicas are pending termination...
- deployment/leeroy-app is ready. [1/2 deployment(s) still pending]
- deployment/leeroy-web is ready.
Deployments stabilized in Xs
Another thing that it doesn't display and that I think is useful to the users is pods that fail to start.
This s something I see with kubectl get -w pods
Contributor
Author
|
@dgageot Thanks! The pod check is upcoming in another PR, but i will show you how it look. Regarding the "UI changes", let me fix it. Thanks |
tejal29
force-pushed
the
health_check_refactor
branch
from
61c7f19 to
a843292
Compare
tejal29
force-pushed
the
health_check_refactor
branch
from
a843292 to
dccc68f
Compare
Contributor
Author
|
@dgageot This is how it looks on my branch |
tejal29
commented
Aug 30, 2019
| if err != nil { | ||
| reason, details := parseKubectlError(err.Error()) | ||
| d.UpdateStatus(details, reason, err) | ||
| if reason != KubectlConnection { |
Contributor
Author
There was a problem hiding this comment.
We would want to keep polling for rollout status if there was a connectivity issue.
balopat
suggested changes
Sep 4, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Another round of nits. This is looking really good, I just have to look again at it with fresh eyes.
dgageot
suggested changes
Sep 4, 2019
This was referenced Sep 4, 2019
Contributor
Author
|
@dgageot Atcually i can.
Once those 2 merged in, i will update this PR. This Pr will be relatively shorter than. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this Pr
Refactor health check to add a Resource interface which will implement the details if a resource is healthy or not.
Print health check summary after every resource check is returned indicating, if the current resource is ready or in error. How many more are remaining.
In case the deployment is in error, the message looks like:
replicas,the user will see the current stautus of the deployment
statusCheckDeadlineSecondsis not reached.Sample full output