Skip to content

Single way of mocking Kubernetes client/dynamic client#2796

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:refacgor-clientset
Sep 4, 2019
Merged

Single way of mocking Kubernetes client/dynamic client#2796
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:refacgor-clientset

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Sep 3, 2019

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2019

Codecov Report

Merging #2796 into master will not change coverage.
The diff coverage is 31.57%.

Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 38.26% <ø> (ø) ⬆️
pkg/skaffold/deploy/status_check.go 63.23% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/secret.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/sources/localdir.go 43.47% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/kaniko.go 46.26% <0%> (ø) ⬆️
pkg/skaffold/kubernetes/owner.go 87.5% <100%> (ø) ⬆️
pkg/skaffold/sync/sync.go 75.2% <100%> (ø) ⬆️
pkg/skaffold/deploy/labels.go 15.85% <33.33%> (ø) ⬆️
pkg/skaffold/kubernetes/client.go 40% <50%> (ø) ⬆️
...ffold/kubernetes/portforward/resource_forwarder.go 88% <66.66%> (ø) ⬆️

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
@dgageot dgageot merged commit 47cf0d5 into GoogleContainerTools:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes kokoro:run runs the kokoro jobs on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants