Unify jibMaven and jibGradle blocks into jib with auto detection#2808
Merged
balopat merged 16 commits intoGoogleContainerTools:masterfrom Sep 11, 2019
Merged
Unify jibMaven and jibGradle blocks into jib with auto detection#2808balopat merged 16 commits intoGoogleContainerTools:masterfrom
balopat merged 16 commits intoGoogleContainerTools:masterfrom
Conversation
…d; add more tests
briandealwis
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
loosebazooka
reviewed
Sep 4, 2019
briandealwis
force-pushed
the
unified-jib
branch
from
60f0abe to
50bf6e0
Compare
chanseokoh
reviewed
Sep 5, 2019
Member
chanseokoh
left a comment
chanseokoh
left a comment
There was a problem hiding this comment.
LGTM. The changes seem innocuous and relatively straightforward.
loosebazooka
reviewed
Sep 5, 2019
Member
loosebazooka
left a comment
loosebazooka
left a comment
There was a problem hiding this comment.
How does https://skaffold.dev/docs/references/yaml/ get updated?
loosebazooka
reviewed
Sep 5, 2019
Member
Author
|
balopat
reviewed
Sep 6, 2019
balopat
reviewed
Sep 6, 2019
briandealwis
force-pushed
the
unified-jib
branch
from
b61635d to
9adc89b
Compare
balopat
added
the
docs-modifications
|
Please visit http://34.94.233.95:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
balopat
suggested changes
Sep 10, 2019
| @@ -190,13 +186,13 @@ each produce a separate container image. | |||
|
|
|||
| #### Maven | |||
|
|
|||
Contributor
There was a problem hiding this comment.
I would love to see the maven/gradle detection logic documented here for our users.
balopat
added
needs-rebase
docs-modifications
|
Error creating deployment, please see controller logs for details. |
container-tools-bot
removed
the
docs-modifications
|
Please visit http://34.94.71.232:1313 to view changes to the docs. |
|
Error creating deployment, please see controller logs for details. |
This was referenced Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the
JibMavenArtifactandJibGradleArtifact(and correspondingjibMaven:andjibGradle:blocks) into a singleJibArtifactandjib:block. Jib now guesses the underlying Jib plugin type based on the file contents within the project.JibArtifactactually has aTypefield — a simple int — for explicitly specifying the plugin type, but it is not current exported as it's only been used for tests. We could make this field explicit later, but we'd need to teach the schema generator how to translate enums.Fixes #1134