Merged
Conversation
Maybe the intents will prevent that redeploy but, still, it’s required at some point to see the results of the rebuild. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
Signed-off-by: David Gageot <david@gageot.net>
nkubala
reviewed
Sep 6, 2019
| }() | ||
|
|
||
| if _, err := r.BuildAndTest(ctx, out, r.changeSet.needsRebuild); err != nil { | ||
| r.changeSet.reset() |
Contributor
There was a problem hiding this comment.
can you explain why we don't need this anymore? don't we want to reset the dirty artifacts so they don't get built again?
Contributor
Author
There was a problem hiding this comment.
r.changeSet.resetBuild() is called by defer.
There's no reason to reset the rest.
nkubala
approved these changes
Sep 9, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
LGTM, this is coming along nicely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.