Removing testing version dependent skaffold config test in examples#2890
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Sep 16, 2019
Merged
Conversation
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
nkubala
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2889
The
./hack/new_version.shscript updates all the config version inexamples/skaffold.yamlThis causes the test
TestGeneratePipeline/user_exampleto fail as the version inexpectedSkaffold.yamlis not updated.The file contents are checked elsewhere in the integration test. This is test case is a dummy test case to add documentation and an example on
generatePipeline