Add buildpacks example to be referenced in buildpacks docs#2893
Merged
tejal29 merged 5 commits intoGoogleContainerTools:masterfrom Sep 17, 2019
Merged
Add buildpacks example to be referenced in buildpacks docs#2893tejal29 merged 5 commits intoGoogleContainerTools:masterfrom
tejal29 merged 5 commits intoGoogleContainerTools:masterfrom
Conversation
added 2 commits
September 16, 2019 13:53
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
priyawadhwa
changed the title
Contributor
|
Can we also add this in the integration test? |
tejal29
suggested changes
Sep 16, 2019
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
hook this into integration tests so we never break this example!
priyawadhwa
force-pushed
the
buildpacks-example
branch
from
58bd970 to
a9099b9
Compare
tejal29
reviewed
Sep 16, 2019
integration/run_test.go
Outdated
| }, | ||
| } | ||
| for _, test := range tests { | ||
| setBuildpacksDefaultBuilder(t) |
Contributor
There was a problem hiding this comment.
This happens on every test. Should we do this before the for loop once?
tejal29
approved these changes
Sep 17, 2019
Contributor
|
This looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the same buildpacks example to
examples/buildpacksandintegration/examples/buildpacksso it can be referenced in the buildpacks tutorial in #2879