Add pod resource with no status check implemented.#2928
Merged
tejal29 merged 8 commits intoGoogleContainerTools:masterfrom Sep 24, 2019
Merged
Add pod resource with no status check implemented.#2928tejal29 merged 8 commits intoGoogleContainerTools:masterfrom
tejal29 merged 8 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #176
Description
User facing changes
Write n/a if not output or log lines changed and no behavior is changed
Before
If log/output changes: Paste the current relevant skaffold output
If behavior changes: describe succinctly the current behavior
After
If log/output changes: Paste skaffold output after your change
If behavior changes: describe succintly the behavior after your change
Next PRs.
In this section describe a list of follow up PRs if the current PR is a part of big feature change.
See example #2811
Write n/a if not applicable.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examplesdir, please copy them tointegration/examplesintegration/examplesdir, should be tested in integration testReviewer Notes
Release Notes
Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.