handle StatusCheck Events implementation logic

[tejal29]

Relates to #176

Description

User facing changes

n/a

Before

n/a
After

n/a

Next PRs.

• Actually call these events in pkg/skaffold/deploy/status_check.go

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [ X] Includes unit tests
• [n/a ] Mentions any output changes.
• [ n/a] Adds documentation as needed: user docs, YAML reference, CLI reference.
• [ na/] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a example to the examples dir, please copy them to integration/examples
• Every new example added in integration/examples dir, should be tested in integration test

Reviewer Notes

• The code flow looks good.
• Unit test added.
• User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

[codecov]

Codecov Report

Merging #2929 into master will increase coverage by 0.22%.
The diff coverage is 97.53%.

Impacted Files	Coverage Δ
pkg/skaffold/event/event.go	91.73% <97.53%> (+3.14%)	⬆️

[priyawadhwa]

We could use "In Progress" instead of "Started" (since In Progress implies that a process has Started) and "Complete" instead of "Succeeded"? That way we have consistency with other events. WDYT?

[tejal29]

So, I had it "completed" instead of "succeeded" befor to be consistent. But one of the comments from IDE team on the internal doc was to change it to "succeeded" so it goes well with "Failed"

We shd change "completed" to "succeeded" which I can do in another PR.

Regarding "started" to "in progress", there is a delay between when the status check startes and when we receive a first update. Hence I added Started for the first event and subsequent events are "in Progress" with a text update on how many resources are pending

[tejal29]

The other alternative is to have a In progress with message "2/2 deployment are still pending" instead of strated

[priyawadhwa]

Sounds good, could we open an issue to change "completed" to "succeeded"?

Personally I'm leaning towards having "In Progress" with the message you said above, just to match, but I don't feel super strongly about it.