Skip to content

added release comments manually#2931

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
balopat:release_comments_manually
Sep 24, 2019
Merged

added release comments manually#2931
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
balopat:release_comments_manually

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Sep 24, 2019

PR [ 2 / 3] breaking down #2917.
Related to #2775.

Description

Adds the comments on config.go files whether they are safe or not safe to modify.

User facing changes

n/a

Next PRs.

  • (6 files) the new comment management logic and hooking it up to release and new_config

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • [] The code flow looks good.
  • [] Unit test added.
  • [] User facing changes look good.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 24, 2019

Codecov Report

Merging #2931 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/schema/v1alpha5/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta1/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta12/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta2/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta8/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta3/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta7/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta9/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta14/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
... and 10 more

@tejal29 tejal29 merged commit 177d0d7 into GoogleContainerTools:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants