Skip to content

Fix Flake TestPollResourceStatus/resource_stabilizes by removing sleep from test.#2934

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:fix_2906
Oct 3, 2019
Merged

Fix Flake TestPollResourceStatus/resource_stabilizes by removing sleep from test.#2934
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:fix_2906

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Sep 24, 2019

Fixes: #2906

Description

Fixes test flake by setting defaultPollingPeriod to 0
User facing changes

Write n/a if not output or log lines changed and no behavior is changed

Before

n/a
After
n/a

Next PRs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

@tejal29 tejal29 changed the title Fix Flake TeTestPollResourceStatus/resource_stabilizes by removing sleep from test. Fix Flake TestPollResourceStatus/resource_stabilizes by removing sleep from test. Sep 24, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2019

Codecov Report

Merging #2934 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/runner/deploy.go 66.66% <0%> (-7.02%) ⬇️
pkg/skaffold/deploy/status_check.go 53.77% <0%> (-2.71%) ⬇️
cmd/skaffold/app/cmd/flags.go 100% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 100% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/render.go 0% <0%> (ø)
cmd/skaffold/app/cmd/render.go 42.1% <0%> (ø)
cmd/skaffold/app/cmd/cmd.go 68.25% <0%> (+0.25%) ⬆️

@tejal29 tejal29 merged commit f961a54 into GoogleContainerTools:master Oct 3, 2019
@tejal29 tejal29 deleted the fix_2906 branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flake TestPollResourceStatus/resource_stabilizes

3 participants