Skip to content

add better docs for recreate pods#2937

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:add_better_recreate_docs
Sep 25, 2019
Merged

add better docs for recreate pods#2937
balopat merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:add_better_recreate_docs

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Sep 24, 2019

Relates to #2877

Description

Add better docs for recreatePods and mention thy are used in helm upgrade to upgrade a chart.

User facing changes

yes

Before

on master https://skaffold.dev/docs/references/yaml/

recreatePods: false | # | if true, Skaffold will send --recreate-pods flag to Helm CLI.

After

recreatePods: false | # |  if `true`, Skaffold will send `--recreate-pods` flag to Helm CLI
  when upgrading a new version of a chart in subsequent dev loop deploy.

Next PRs.

In this section describe a list of follow up PRs if the current PR is a part of big feature change.

See example #2811

Write n/a if not applicable.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

@container-tools-bot
Copy link
Copy Markdown

Please visit http://34.94.71.232:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 24, 2019
@balopat balopat merged commit 78b3c71 into GoogleContainerTools:master Sep 25, 2019
@tejal29 tejal29 deleted the add_better_recreate_docs branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants