Skip to content

Implement 'skaffold render' for kubectl deployer#2943

Merged
nkubala merged 3 commits intoGoogleContainerTools:masterfrom
nkubala:render-kubectl
Oct 2, 2019
Merged

Implement 'skaffold render' for kubectl deployer#2943
nkubala merged 3 commits intoGoogleContainerTools:masterfrom
nkubala:render-kubectl

Conversation

@nkubala
Copy link
Copy Markdown
Contributor

@nkubala nkubala commented Sep 25, 2019 •
edited by tejal29
Loading

Relates to #1187
Example outputs:

➜  getting-started skaffold render
apiVersion: v1
kind: Pod
metadata:
  name: getting-started
  namespace: default
spec:
  containers:
  - image: gcr.io/k8s-skaffold/skaffold-example:v0.37.0-409-g16d01549d@sha256:ae2cf00b749df139b100fa5b671ec636ec75fa26950644ac9c7a6e077a8a0414
    name: getting-started


➜  getting-started skaffold run --render-only
Generating tags...
 - gcr.io/k8s-skaffold/skaffold-example -> gcr.io/nkubala-demo/gcr.io/k8s-skaffold/skaffold-example:v0.37.0-409-g16d01549d
Tags generated in 31.518799ms
Checking cache...
 - gcr.io/k8s-skaffold/skaffold-example: Found
Cache check complete in 604.78383ms
Tags used in deployment:
 - gcr.io/k8s-skaffold/skaffold-example -> gcr.io/k8s-skaffold/skaffold-example:v0.37.0-409-g16d01549d@sha256:ae2cf00b749df139b100fa5b671ec636ec75fa26950644ac9c7a6e077a8a0414
apiVersion: v1
kind: Pod
metadata:
  name: getting-started
  namespace: default
spec:
  containers:
  - image: gcr.io/k8s-skaffold/skaffold-example:v0.37.0-409-g16d01549d@sha256:ae2cf00b749df139b100fa5b671ec636ec75fa26950644ac9c7a6e077a8a0414
    name: getting-started

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #2943 into master will decrease coverage by 0.03%.
The diff coverage is 36.95%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/cli.go 94.11% <ø> (-0.17%) ⬇️
pkg/skaffold/deploy/kubectl.go 64.17% <36.95%> (-1.37%) ⬇️

tejal29
tejal29 previously requested changes Sep 25, 2019
View reviewed changes
@tejal29 tejal29 mentioned this pull request Oct 1, 2019
Closed
tejal29
tejal29 reviewed Oct 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except 1 nit.

@nkubala nkubala merged commit 08551a7 into GoogleContainerTools:master Oct 2, 2019
@nkubala nkubala deleted the render-kubectl branch October 2, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

1 more reviewer

@tejal29 tejal29 tejal29 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkubala @tejal29 @googlebot