Skip to content

Reset State on Build#2944

Merged
tejal29 merged 3 commits intoGoogleContainerTools:masterfrom
tejal29:reset_state
Oct 1, 2019
Merged

Reset State on Build#2944
tejal29 merged 3 commits intoGoogleContainerTools:masterfrom
tejal29:reset_state

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Sep 25, 2019

Relates to #2940
Reset Build state when a Build Trigger is received or via Control API, a build request is sent.

Description

User facing changes

yes.

Before

  1. skaffold Build from master, run with RPC.
cd examples/getting-started
skaffold dev --default-repo=gcr.io/tejal-test --trigger manual --enable-rpc 
  1. Change a file

  2. Curl the state

 curl localhost:50052/v1/state | jq
{
  "buildState": {
    "artifacts": {
      "gcr.io/tejal-test/gcr.io/k8s-skaffold/skaffold-example": "In Progress"
    }
  },
  "deployState": {
    "status": "Complete"
  }
}

After

  1. skaffold Build from master, run with RPC.
cd examples/getting-started
skaffold dev --default-repo=gcr.io/tejal-test --trigger manual --enable-rpc 
  1. Change a file

  2. Curl the state

 curl localhost:50052/v1/state | jq
{
  "buildState": {
    "artifacts": {
      "gcr.io/tejal-test/gcr.io/k8s-skaffold/skaffold-example": "In Progress"
    }
  },
  "deployState": {
    "status": "Not Started"
  },
  "statusCheckState": {
    "status": "Not Started"
  }
}

Next PRs.

  • Reset State on Deploy

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2019

Codecov Report

Merging #2944 into master will increase coverage by 0.02%.
The diff coverage is 92.3%.

Impacted Files Coverage Δ
pkg/skaffold/server/endpoints.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/dev.go 67.64% <100%> (+0.32%) ⬆️
pkg/skaffold/event/event.go 89.37% <100%> (+0.78%) ⬆️

@tejal29 tejal29 merged commit 567a080 into GoogleContainerTools:master Oct 1, 2019
@tejal29 tejal29 deleted the reset_state branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants