Properly tag images with digest when using helm#2956
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Oct 4, 2019
michaelbeaumont:mb/helm_tagging
Merged
Properly tag images with digest when using helm#2956dgageot merged 1 commit intoGoogleContainerTools:masterfrom michaelbeaumont:mb/helm_tagging
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
michaelbeaumont:mb/helm_tagging
Conversation
michaelbeaumont
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
Contributor
|
/cc @dgageot |
dgageot
approved these changes
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2624 again as reintroduced by #2624
Description
User facing changes
Include digest in image tag when deploying with helm
Before
Skaffold did not output the digest, leading to outdated deployments
After
Ensure that the correct digest of an image is used.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Adds documentation as needed: user docs, YAML reference, CLI reference.Adds integration tests if needed.See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examplesdir, please copy them tointegration/examplesintegration/examplesdir, should be tested in integration testReviewer Notes
Release Notes