Fix bugs in insecure registries for kaniko#2974
Merged
priyawadhwa merged 6 commits intoGoogleContainerTools:masterfrom Oct 10, 2019
Merged
Fix bugs in insecure registries for kaniko#2974priyawadhwa merged 6 commits intoGoogleContainerTools:masterfrom
priyawadhwa merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
This PR: 1. Passes in the `--insecure-registry` flag to kaniko, which allows for insecure image pull and pushes 2. Updates the kaniko image to one that incorporates this bug fix in kaniko: GoogleContainerTools/kaniko#685. This bug fix is required for insecure registries to work with caching in kaniko.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
tejal29
approved these changes
Oct 2, 2019
added 3 commits
October 2, 2019 14:43
Contributor
Author
|
@tejal29 I added an integration test after your approval -- could you PTAL? |
tejal29
approved these changes
Oct 3, 2019
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
Excellent!
I ran it 10 times in parallel in 3 go test processes. The max time each test run ran was around 4 mins.
The timeout for ip to stabilize is 5 mins in kubernetes.GetExternalIP
Lets merge it and see what happens.
balopat
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Passes in the
--insecure-registryflag to kaniko, which allows forinsecure image pull and pushes
Updates the kaniko image to one that incorporates this bug fix in
kaniko: insecure flag not honored in cache kaniko#685. This
bug fix is required for insecure registries to work with caching in
kaniko.
Adds an integration test
I found these bugs while trying to push to my own insecure registry.
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes