link validation in docs#2984
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Oct 4, 2019
Merged
Conversation
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
balopat
added
docs-modifications
|
Error creating deployment, please see controller logs for details. |
container-tools-bot
removed
the
docs-modifications
Contributor
Author
|
oops, the doc previewer ran out of IPs (quota was 8, I requested an increase): |
balopat
added
the
docs-modifications
|
Please visit http://35.236.72.244:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
dgageot
approved these changes
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to in case of new feature, this should point to issue/(s) which describes the feature
Description
Enables link validation for relative links within our docs. This is useful as guards against mistakes.
However, due to gohugoio/hugo#2424 this means that links are now all opened in the same tab, even external ones. I believe that the validation is useful enough to take the hit on the external link openings. Opinions welcome :)
User facing changes
External links are now opened in the same tab. (sideeffect of gohugoio/hugo#2424)
Before
External links are currently opened in a new tab (
target="_blank")After
External links are now opened in the same tab.
Reviewer Notes