New version v1beta17#3041
Merged
balopat merged 5 commits intoGoogleContainerTools:masterfrom Oct 16, 2019
Merged
Conversation
feloy
requested review from
TadCordle,
balopat,
briandealwis,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
balopat
suggested changes
Oct 14, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
just a nit, otherwise looks good, thank you!
tejal29
suggested changes
Oct 16, 2019
pkg/skaffold/deploy/kustomize.go
Outdated
| event.DeployFailed(err) | ||
| return NewDeployErrorResult(errors.Wrap(err, "reading manifests")) | ||
| } | ||
| fmt.Printf("\n\n\n\n%v\n\n\n\n", manifests.String()) |
Contributor
Contributor
|
@feloy looks like the linter failed. Can you please fix it. |
tejal29
approved these changes
Oct 16, 2019
Contributor
balopat
approved these changes
Oct 16, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new version
to be able to change config in #3040