Skip to content

Warn about unused configs#3046

Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-2972
Oct 14, 2019
Merged

Warn about unused configs#3046
balopat merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-2972

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Oct 14, 2019

Fixes #2972

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#2972

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3046 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 57.45% <100%> (ø) ⬆️

Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@balopat balopat merged commit 6afc2b1 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skaffold init erroneously thinks there are unused builder configs

4 participants