Skip to content

Update docker and go-containerregistry#3053

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:update-docker-ggcr
Oct 14, 2019
Merged

Update docker and go-containerregistry#3053
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:update-docker-ggcr

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Oct 14, 2019

This has to be merged after #3052

It might help with #1649

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3053 into master will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted Files Coverage Δ
pkg/skaffold/docker/auth.go 55.76% <27.27%> (-7.03%) ⬇️

Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember making these exact code changes when i tried to bump the deps a few months back 😆

@balopat
Copy link
Copy Markdown
Contributor

balopat commented Oct 14, 2019

#3052 is merged, please rebase.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the update-docker-ggcr branch from d1fd24b to 429fcef Compare October 14, 2019 19:31
@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Oct 14, 2019

@balopat done!

@dgageot dgageot merged commit ef120d6 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants