Skip to content

[Cache] Ignore file not found#3066

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:cache-not-found
Oct 16, 2019
Merged

[Cache] Ignore file not found#3066
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:cache-not-found

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Oct 16, 2019

Continue computing the hash for the files that are found.

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2019

Codecov Report

Merging #3066 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/cache/hash.go 75% <100%> (+2.69%) ⬆️

Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

Continue computing the hash for the files that
are found.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 98bd718 into GoogleContainerTools:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants