Skip to content

Docs updates#3079

Merged
nkubala merged 2 commits intoGoogleContainerTools:masterfrom
nkubala:docs-updates
Oct 17, 2019
Merged

Docs updates#3079
nkubala merged 2 commits intoGoogleContainerTools:masterfrom
nkubala:docs-updates

Conversation

@nkubala
Copy link
Copy Markdown
Contributor

@nkubala nkubala commented Oct 17, 2019

No description provided.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Oct 17, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.236.38.41:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 17, 2019
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple of nits! Thank you!

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2019

Codecov Report

Merging #3079 into master will not change coverage.
The diff coverage is 35.29%.

Impacted Files Coverage Δ
pkg/skaffold/util/util.go 86.48% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/initializer/init.go 57.45% <ø> (ø) ⬆️
pkg/skaffold/docker/client.go 73.73% <ø> (ø) ⬆️
pkg/skaffold/kubernetes/client.go 40% <0%> (ø) ⬆️
pkg/skaffold/debug/debug.go 43.33% <0%> (ø) ⬆️
pkg/skaffold/deploy/status_check.go 53.77% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/sources/localdir.go 43.47% <0%> (ø) ⬆️
...ffold/kubernetes/portforward/resource_forwarder.go 88% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/secret.go 36.2% <0%> (ø) ⬆️
... and 7 more

@nkubala nkubala merged commit 1f2f338 into GoogleContainerTools:master Oct 17, 2019
@nkubala nkubala deleted the docs-updates branch October 17, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants