[Custom] [Deprecation] Use $IMAGE instead of $IMAGES #3084
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Oct 21, 2019
Merged
[Custom] [Deprecation] Use $IMAGE instead of $IMAGES #3084dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
tejal29
previously approved these changes
Oct 18, 2019
tejal29
changed the title
tejal29
dismissed
their stale review
Please mention this in current deprecation notices.
Contributor
|
Can you please add these to current Deprecation notices to the Deprecation policy as well ? We shd make sure this is captured in Release notes. Added Deprecation to the title. |
Contributor
Author
|
Thanks @tejal29! I added a section in the Deprecation notices |
Fixes GoogleContainerTools#3081 Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3081
$IMAGESis still passed, for compatibility reasons, but it no documented anymoreSigned-off-by: David Gageot david@gageot.net