Skip to content

[Custom] Clearer message when image was not built#3085

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:custom-clear-error
Oct 18, 2019
Merged

[Custom] Clearer message when image was not built#3085
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:custom-clear-error

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Oct 18, 2019

When the custom script failed to build the image with the provided tag, it used to give an error like:

building [img]: Error parsing reference: "" is not a valid repository/tag: invalid reference format 

It's now:

building [img]: build artifact: The custom script didn't produce an image with tag [img:tag]

Will help debugs issue like #3077

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2019

Codecov Report

Merging #3085 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/custom.go 13.33% <0%> (-6.67%) ⬇️

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the custom-clear-error branch from 1413308 to 7920748 Compare October 18, 2019 09:50
@tejal29 tejal29 merged commit 00a953b into GoogleContainerTools:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants