Skip to content

Fix —force=false#3086

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-#2848
Oct 18, 2019
Merged

Fix —force=false#3086
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-#2848

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Oct 18, 2019

Switched to using a single flag.

Fixes #2848

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2019

Codecov Report

Merging #3086 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
pkg/skaffold/config/options.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/cmd.go 66.92% <0%> (-1.08%) ⬇️
pkg/skaffold/deploy/kubectl/cli.go 94.11% <100%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 74.4% <100%> (ø) ⬆️
pkg/skaffold/deploy/helm.go 77.25% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 64.17% <100%> (ø) ⬆️

Copy link
Copy Markdown
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"skaffold deploy --force=false" still force updates deployments

3 participants