Skip to content

Clarify debug docs for deprecated Workload APIs#3092

Merged
tejal29 merged 3 commits intoGoogleContainerTools:masterfrom
briandealwis:debug-deprecations
Oct 18, 2019
Merged

Clarify debug docs for deprecated Workload APIs#3092
tejal29 merged 3 commits intoGoogleContainerTools:masterfrom
briandealwis:debug-deprecations

Conversation

@briandealwis
Copy link
Copy Markdown
Member

Minor doc modification to expand on debug not handling deprecated workload objects.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2019

Codecov Report

Merging #3092 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/build/local/custom.go 13.33% <0%> (-6.67%) ⬇️
cmd/skaffold/app/cmd/cmd.go 66.92% <0%> (-1.08%) ⬇️
pkg/skaffold/runner/deploy.go 66.66% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 100% <0%> (ø) ⬆️
pkg/skaffold/runner/build_deploy.go 67.18% <0%> (+0.99%) ⬆️
pkg/skaffold/deploy/status_check.go 55.75% <0%> (+1.97%) ⬆️

tejal29
tejal29 previously approved these changes Oct 18, 2019
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.236.79.92:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
- move _Deprecated Workload API_ into _Limitations_ section
- render other shortcode to HTML
@briandealwis
Copy link
Copy Markdown
Member Author

Unsure why but {{% alert %}} doesn't seem to render the content as markdown. Moved this warning into the Limitations section. Which is where it really belonged.

@briandealwis briandealwis added the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.236.1.119:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 18, 2019
@tejal29 tejal29 merged commit b87d90a into GoogleContainerTools:master Oct 18, 2019
@briandealwis briandealwis deleted the debug-deprecations branch November 11, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants