Skip to content

Prepare kubectl and helm deployers for --kubeconfig flag#3108

Merged
balopat merged 3 commits intoGoogleContainerTools:masterfrom
corneliusweig:w/kubeconfig-kubectl-helm
Nov 6, 2019
Merged

Prepare kubectl and helm deployers for --kubeconfig flag#3108
balopat merged 3 commits intoGoogleContainerTools:masterfrom
corneliusweig:w/kubeconfig-kubectl-helm

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

Relates to #2699

Should merge before : #3100

Should merge after : n/a

Description

Adds the infrastructure to pass the --kubeconfig CLI setting to kubectl and helm.

User facing changes

n/a

Next PRs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

This prepares for upcoming commits which introduce the `--kubeconfig`
flag.
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2019

Codecov Report

Merging #3108 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/config/options.go 100% <ø> (ø) ⬆️
pkg/skaffold/kubectl/cli.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/helm.go 77.5% <100%> (+0.24%) ⬆️

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@corneliusweig corneliusweig force-pushed the w/kubeconfig-kubectl-helm branch from cc2a4b6 to a20242b Compare October 22, 2019 19:49
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2019
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 30, 2019
@balopat balopat merged commit a29ee9a into GoogleContainerTools:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes kokoro:run runs the kokoro jobs on a PR size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants