Fix writing rendered manifests to files#3152
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Nov 1, 2019
Merged
Fix writing rendered manifests to files#3152tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
balopat
approved these changes
Nov 1, 2019
Codecov Report
|
tejal29
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this change, trying to run
skaffold render --output file.txtwould fail withthis was happening because we were trying to do an
os.Open()on a file that didn't exist. now, we'll just do anos.OpenFile()with the right opening mode, and just callfile.WriteString()rather than creating a newWriter.