[example] update apiVersion of Deployment#3161
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Nov 6, 2019
oke-py:apps/v1
Merged
[example] update apiVersion of Deployment#3161dgageot merged 1 commit intoGoogleContainerTools:masterfrom oke-py:apps/v1
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
oke-py:apps/v1
Conversation
oke-py
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
oke-py
changed the title
dgageot
suggested changes
Nov 6, 2019
Contributor
|
Please rebase your PR and them it's all good! |
Contributor
Author
|
I rebased and force-pushed |
dgageot
approved these changes
Nov 6, 2019
Contributor
|
@oke-py you rock! |
Contributor
Author
|
Travis CI failed because of master branch. I rebased again to take in the patch for master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to in case of new feature, this should point to issue/(s) which describes the feature
Fixes #3160. in case of a bug fix, this should point to a bug and any other related issue(s)
Should merge before : list any PRs that depend on this PR
Should merge after : list any PRs that are prerequisites to this PR
Description
User facing changes
n/a
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes