Skip to content

[docs] change config version to v1#3175

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:rename_config_version
Nov 5, 2019
Merged

[docs] change config version to v1#3175
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:rename_config_version

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Nov 5, 2019

Change config version to v1 everywhere in docs.

Before

tejaldesai@@skaffold1 (rename_config_version)$ grep -r 'skaffold\/v1' docs/
docs/content/en/samples/builders/custom-buildpacks/skaffold.yaml:apiVersion: skaffold/v1beta13

docs/content/en/docs/design/api.md:{"result":{"timestamp":"2019-10-16T18:26:11.385251549Z","event":
{"metaEvent":{"entry":"Starting Skaffold: {Version:v0.39.0-16-g5bb7c9e0 
ConfigVersion:skaffold/v1beta15
GitVersion: GitCommit:5bb7c9e078e4d522a5ffc42a2f1274fd17d75902 GitTreeState:dirty BuildDate:2019-10-03T15:01:29Z GoVersion:go1.13rc1 Compiler:gc Platform:linux/amd64}"}}}}

docs/content/en/docs/pipeline-stages/init.md:apiVersion: skaffold/v1beta15

docs/config.toml:skaffold_version = "skaffold/v1beta18"

After

tejaldesai@@skaffold1 (rename_config_version)$ grep -r 'skaffold\/v1' docs/
docs/content/en/samples/builders/custom-buildpacks/skaffold.yaml:apiVersion: skaffold/v1

docs/content/en/docs/design/api.md:{"result":{"timestamp":"2019-10-16T18:26:11.385251549Z","event":
{"metaEvent":{"entry":"Starting Skaffold: {Version:v0.39.0-16-g5bb7c9e0 
ConfigVersion:skaffold/v1 
GitVersion: GitCommit:5bb7c9e078e4d522a5ffc42a2f1274fd17d75902 GitTreeState:dirty BuildDate:2019-10-03T15:01:29Z GoVersion:go1.13rc1 Compiler:gc Platform:linux/amd64}"}}}}

docs/content/en/docs/pipeline-stages/init.md:apiVersion: skaffold/v1

docs/config.toml:skaffold_version = "skaffold/v1beta18"

@tejal29 tejal29 added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 5, 2019
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.235.117.222:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2019

Codecov Report

Merging #3175 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 merged commit ac1f035 into GoogleContainerTools:master Nov 5, 2019
@tejal29 tejal29 deleted the rename_config_version branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes priority/p0 Highest priority. We are actively looking at delivering it. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants