Skip to content

[docs] Cleanup docs#3176

Merged
balopat merged 14 commits intoGoogleContainerTools:masterfrom
balopat:skaffold_delete
Nov 7, 2019
Merged

[docs] Cleanup docs#3176
balopat merged 14 commits intoGoogleContainerTools:masterfrom
balopat:skaffold_delete

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Nov 5, 2019

  • Talks about Cleanup skaffold delete and the image pruning
  • adds a diagram with all the phases in the workflow page

@balopat balopat added docs-modifications runs the docs preview service on the given PR and removed cla: yes labels Nov 5, 2019
@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 5, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.236.13.246:1313 to view changes to the docs.

@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Nov 5, 2019

Looks good!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2019

Codecov Report

Merging #3176 into master will not change coverage.
The diff coverage is n/a.

@tejal29 tejal29 added the priority/p0 Highest priority. We are actively looking at delivering it. label Nov 5, 2019
@balopat balopat marked this pull request as ready for review November 6, 2019 05:31
dgageot
dgageot previously requested changes Nov 6, 2019
@balopat
Copy link
Copy Markdown
Contributor Author

balopat commented Nov 6, 2019

Thanks for the review @dgageot :) I'll fix those up!

@balopat balopat requested a review from dgageot November 6, 2019 16:16
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
@container-tools-bot
Copy link
Copy Markdown

Please visit http://35.235.117.222:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Nov 6, 2019
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superb!!

balopat and others added 11 commits November 6, 2019 11:16
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
Co-Authored-By: Nick Kubala <nkubala@users.noreply.github.com>
@tejal29 tejal29 dismissed dgageot’s stale review November 7, 2019 00:12

addressed changed

@balopat balopat merged commit 4ff6680 into GoogleContainerTools:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes priority/p0 Highest priority. We are actively looking at delivering it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants